Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qrm): fix advisor drop cache handler missing nbytes parameter #500

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Mar 6, 2024

fix(qrm): fix advisor drop cache handler missing nbytes parameter

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 55.10%. Comparing base (d74807b) to head (3a574c8).

Files Patch % Lines
...ins/memory/dynamicpolicy/policy_advisor_handler.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
+ Coverage   55.02%   55.10%   +0.07%     
==========================================
  Files         512      512              
  Lines       56642    56650       +8     
==========================================
+ Hits        31170    31215      +45     
+ Misses      22149    22099      -50     
- Partials     3323     3336      +13     
Flag Coverage Δ
unittest 55.10% <72.22%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csfldf csfldf merged commit c7d9d3f into kubewharf:main Mar 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants